Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: can not change ref type in menu item modal #4644

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Sep 22, 2023

What type of PR is this?

/kind bug
/area console
/milestone 2.10.x

What this PR does / why we need it:

修复菜单项编辑表单中,切换分类和标签类型可能导致分类或者标签选择框异常的问题。

image

Which issue(s) this PR fixes:

Fixes #4643

Special notes for your reviewer:

测试方式:

  1. 新建菜单项,先选择分类或者标签,然后选择另外一个类型,观察选择框是否正常。

Does this PR introduce a user-facing change?

修复 Console 端菜单项编辑表单中可能无法正常切换类型的问题。

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 22, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.10.x milestone Sep 22, 2023
@f2c-ci-robot f2c-ci-robot bot requested a review from JohnNiang September 22, 2023 04:24
@f2c-ci-robot f2c-ci-robot bot added the area/console Issues or PRs related to the Halo Console label Sep 22, 2023
@f2c-ci-robot f2c-ci-robot bot requested a review from wzrove September 22, 2023 04:24
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #4644 (dc836eb) into main (84f413d) will not change coverage.
Report is 11 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4644   +/-   ##
=========================================
  Coverage     61.11%   61.11%           
  Complexity     2570     2570           
=========================================
  Files           374      374           
  Lines         13171    13171           
  Branches        938      938           
=========================================
  Hits           8049     8049           
  Misses         4669     4669           
  Partials        453      453           

@LIlGG
Copy link
Member

LIlGG commented Sep 26, 2023

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2023
@JohnNiang JohnNiang merged commit 1585a26 into halo-dev:main Sep 26, 2023
2 checks passed
@ruibaby ruibaby modified the milestones: 2.10.x, 2.10.0 Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

在菜单项编辑表单中,分类和标签输入类型有冲突
4 participants